From 46b029473ea52683de500cef41063e8d3202e729 Mon Sep 17 00:00:00 2001 From: drHuangMHT Date: Fri, 10 Jan 2025 15:07:42 +0800 Subject: [PATCH 1/4] changelog --- swarm/CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/swarm/CHANGELOG.md b/swarm/CHANGELOG.md index f1ad994bd1b..486d8322268 100644 --- a/swarm/CHANGELOG.md +++ b/swarm/CHANGELOG.md @@ -12,6 +12,13 @@ - Update default for idle-connection-timeout to 10s. See [PR 4967](https://github.com/libp2p/rust-libp2p/pull/4967). +- Deprecate `ConnectionHandler::{InboundOpenInfo, OutboundOpenInfo}` associated type. + Previously, users can tag pending substreams with custom data and retrieve the data + after the substream has been negotiated. + But substreams themselves are completely interchangeable, users should instead track + additional data inside `ConnectionHandler` after negotiation. + See [PR 5242](https://github.com/libp2p/rust-libp2p/pull/5242). + ## 0.45.1 - Update `libp2p-swarm-derive` to version `0.35.0`, see [PR 5545] From 8549afbfb4a1a6e81fde65882a10c1eb98417f1a Mon Sep 17 00:00:00 2001 From: drHuangMHT Date: Fri, 10 Jan 2025 18:21:54 +0800 Subject: [PATCH 2/4] changelog for libp2p --- libp2p/CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libp2p/CHANGELOG.md b/libp2p/CHANGELOG.md index 9e7194e2a69..08ea0adb6e0 100644 --- a/libp2p/CHANGELOG.md +++ b/libp2p/CHANGELOG.md @@ -15,6 +15,13 @@ - Expose swarm builder phase errors. See [PR 5726](https://github.com/libp2p/rust-libp2p/pull/5726). +- Deprecate `ConnectionHandler::{InboundOpenInfo, OutboundOpenInfo}` associated type. + Previously, users can tag pending substreams with custom data and retrieve the data + after the substream has been negotiated. + But substreams themselves are completely interchangeable, users should instead track + additional data inside `ConnectionHandler` after negotiation. + See [PR 5242](https://github.com/libp2p/rust-libp2p/pull/5242). + ## 0.54.1 - Update individual crates. From cd17455f6822f10996b94cfdf57242d4ab90adf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Oliveira?= Date: Fri, 10 Jan 2025 12:40:46 +0000 Subject: [PATCH 3/4] Update libp2p/CHANGELOG.md --- libp2p/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libp2p/CHANGELOG.md b/libp2p/CHANGELOG.md index 08ea0adb6e0..59bf2e81383 100644 --- a/libp2p/CHANGELOG.md +++ b/libp2p/CHANGELOG.md @@ -16,7 +16,7 @@ See [PR 5726](https://github.com/libp2p/rust-libp2p/pull/5726). - Deprecate `ConnectionHandler::{InboundOpenInfo, OutboundOpenInfo}` associated type. - Previously, users can tag pending substreams with custom data and retrieve the data + Previously, users could tag pending sub streams with custom data and retrieve the data after the substream has been negotiated. But substreams themselves are completely interchangeable, users should instead track additional data inside `ConnectionHandler` after negotiation. From 76b30c8567a336276b0c417ca69d8f796dd22759 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Oliveira?= Date: Fri, 10 Jan 2025 12:40:52 +0000 Subject: [PATCH 4/4] Update swarm/CHANGELOG.md --- swarm/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swarm/CHANGELOG.md b/swarm/CHANGELOG.md index 486d8322268..250d347430b 100644 --- a/swarm/CHANGELOG.md +++ b/swarm/CHANGELOG.md @@ -13,7 +13,7 @@ See [PR 4967](https://github.com/libp2p/rust-libp2p/pull/4967). - Deprecate `ConnectionHandler::{InboundOpenInfo, OutboundOpenInfo}` associated type. - Previously, users can tag pending substreams with custom data and retrieve the data + Previously, users could tag pending sub streams with custom data and retrieve the data after the substream has been negotiated. But substreams themselves are completely interchangeable, users should instead track additional data inside `ConnectionHandler` after negotiation.