rename fn and more comments on UB

ibus-gokien/src/engine.rs

@@ -145,7 +145,8 @@ impl IBusGokienEngine {
         self.core.clear();
     }
 
-    fn assert_is_self<'a>(engine: *mut IBusEngine) -> &'a mut Self {
+    // call more than once in scope is UB.
+    unsafe fn assert_is_self<'a>(engine: *mut IBusEngine) -> &'a mut Self {
         let gokien: *mut Self = engine.cast();
         Self::is_self(gokien);
         unsafe { &mut *gokien }

ibus-gokien/src/main.rs

@@ -69,7 +69,7 @@ fn prepare(ibus: bool) -> Bus {
     info!(?bus);
     bus.register_disconnected_signal();
     let file_path = get_engine_xml_path();
-    let component = Component::new_from_file(&file_path);
+    let component = Component::from_file(&file_path);
     let component_name = component.get_name();
     info!(?component_name);
 

ribus/src/lib.rs

@@ -159,7 +159,7 @@ impl Factory {
 pub struct Component(*mut c::IBusComponent);
 
 impl Component {
-    pub fn new_from_file(path: &CStr) -> Self {
+    pub fn from_file(path: &CStr) -> Self {
         unsafe {
             let comp = c::ibus_component_new_from_file(path.as_ptr());
             Self(comp)
@@ -188,7 +188,7 @@ impl Component {
 }
 
 // The recommended way to load engine description data is using
-// `Component::new_from_file` to load a component file, which also includes
+// `Component::from_file` to load a component file, which also includes
 // engine description data.
 #[repr(transparent)]
 pub struct EngineDesc(*mut c::IBusEngineDesc);