Builds get stuck and fail in github workflow at "Performing Test ALL_SANITIZERS_AVAILABLE"

[vik748]

Description

During CI/CD the build gets stuck at "Performing Test ALL_SANITIZERS_AVAILABLE".

Our CI/CD uses earthly and runs as a github workflow on a self-hosted runner on Amazon EC2. Every so often the cmake .. step get stuck at "Performing Test ALL_SANITIZERS_AVAILABLE" and eventually fails the job.

I see a related problem mentioned in #582. I tried skipping the sanitizer tests completely by setting the flag "-DCMAKE_CROSSCOMPILING=ON" but this doesn't work since I believe CMAKE_CROSSCOMPILING is an internal cmake flag which is automatically set.

Example/How to Reproduce

Example Earthfile used in the workflow:

VERSION 0.8

build:
    FROM ubuntu

    ARG CPR_VERSION=1.10.5

    # Install package dependencies
    RUN apt-get -q update && apt-get -q install -y --no-install-recommends \
            libcurl4-openssl-dev \
            build-essential \
            cmake \
            libssl-dev \
        && apt-get clean && rm -rf /var/lib/apt/lists/*

    WORKDIR /
    GIT CLONE --branch $CPR_VERSION https://github.com/libcpr/cpr cpr
    WORKDIR /cpr

    RUN mkdir build \
        && cd build \
        && cmake -DCPR_USE_SYSTEM_CURL=ON -DCPR_ENABLE_SSL=ON -DCMAKE_BUILD_TYPE=Release .. \
        && cmake --build . --parallel 4 --config Release \
        && cmake --install . --config Release \
        && ldconfig

Possible Fix

Add a flag which can explicitly turn off the sanitizer tests.

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

• OS: Ubuntu
• Version: 20.04
  See Earthly file above for specific details.

[COM8]

@vik748 thanks for reporting. Interesting that this only happens with the ALL_SANITIZERS_AVAILABLE test...
Let me see if I can throw together a quick fix for that :)

[COM8]

#1204 should fix it. Can you please confirm?

[vik748]

@COM8 thanks for the prompt action. So looks like the Sanitizer tests are being turned off by default. It certainly resolves my issues. Hopefully, it doesn't have undesired side-effects for others.

[COM8]

Should not introduce any side effects. We just don't check for sanitizers any more if they are not enabled in the first place.

[vik748]

@COM8 can we pls backport this fix into 1.10.x. We use influxdb which doesn't seem to build with 1.11.x on Ubuntu 20.04. Started #1208