- More tweaks to implementations of setTo() for array types

- Updated testing

Author: lessthanoptimal

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleArray_B.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleArray_B extends GenericPackedArrayChecks<TupleDesc_B> {
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleArray_F64.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -21,6 +21,7 @@
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
 import org.ejml.UtilEjml;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -51,4 +52,7 @@ class TestPackedTupleArray_F64 extends GenericPackedArrayChecks<TupleDesc_F64> {
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleArray_S8.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleArray_S8 extends GenericPackedArrayChecks<TupleDesc_S8> {
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleArray_U8.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleArray_U8 extends GenericPackedArrayChecks<TupleDesc_U8> {
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleBigArray_B.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleBigArray_B extends GenericPackedArrayChecks<TupleDesc_B> {
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleBigArray_F64.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -21,6 +21,7 @@
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
 import org.ejml.UtilEjml;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -51,4 +52,7 @@ class TestPackedTupleBigArray_F64 extends GenericPackedArrayChecks<TupleDesc_F64
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleBigArray_S8.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleBigArray_S8 extends GenericPackedArrayChecks<TupleDesc_S8>
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-feature/src/test/java/boofcv/struct/feature/TestPackedTupleBigArray_U8.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, Peter Abeles. All Rights Reserved.
+ * Copyright (c) 2024, Peter Abeles. All Rights Reserved.
  *
  * This file is part of BoofCV (http://boofcv.org).
  *
@@ -20,6 +20,7 @@
 
 import boofcv.struct.PackedArray;
 import boofcv.struct.packed.GenericPackedArrayChecks;
+import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -50,4 +51,7 @@ class TestPackedTupleBigArray_U8 extends GenericPackedArrayChecks<TupleDesc_U8>
 		}
 		fail("The tuples are identical");
 	}
+
+	// not implemented yet
+	@Test void setTo_Standard(){}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedArrayPoint2D_F64.java

@@ -21,6 +21,7 @@
 import boofcv.misc.BoofLambdas;
 import boofcv.struct.PackedArray;
 import georegression.struct.point.Point2D_F64;
+import lombok.Getter;
 import org.ddogleg.struct.DogArray_F64;
 
 /**
@@ -31,10 +32,11 @@
 public class PackedArrayPoint2D_F64 implements PackedArray<Point2D_F64> {
 	private static final int DOF = 2;
 
-	// Stores tuple in a single continuous array
-	public final DogArray_F64 array;
+	/** Stores tuple in a single continuous array */
+	@Getter private final DogArray_F64 array;
+
 	// tuple that the result is temporarily written to
-	public final Point2D_F64 temp = new Point2D_F64();
+	private final Point2D_F64 temp = new Point2D_F64();
 
 	public PackedArrayPoint2D_F64() {
 		array = new DogArray_F64();
@@ -108,9 +110,7 @@ public final void append( double x, double y ) {
 	 * @return Reference to 'this'
 	 */
 	public PackedArrayPoint2D_F64 setTo( PackedArrayPoint2D_F64 src ) {
-		reset();
-		reserve(src.size());
-		src.forIdx(0, src.size(), ( idx, p ) -> append(p.x, p.y));
+		array.setTo(src.array);
 		return this;
 	}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedArrayPoint2D_I16.java

@@ -21,6 +21,7 @@
 import boofcv.misc.BoofLambdas;
 import boofcv.struct.PackedArray;
 import georegression.struct.point.Point2D_I16;
+import lombok.Getter;
 import org.ddogleg.struct.DogArray_I16;
 
 /**
@@ -31,10 +32,11 @@
 public class PackedArrayPoint2D_I16 implements PackedArray<Point2D_I16> {
 	private static final int DOF = 2;
 
-	// Stores tuple in a single continuous array
-	public final DogArray_I16 array;
+	/** Stores tuple in a single continuous array */
+	@Getter private final DogArray_I16 array;
+
 	// tuple that the result is temporarily written to
-	public final Point2D_I16 temp = new Point2D_I16();
+	private final Point2D_I16 temp = new Point2D_I16();
 
 	public PackedArrayPoint2D_I16() {
 		array = new DogArray_I16();
@@ -108,9 +110,7 @@ public final void append( int x, int y ) {
 	 * @return Reference to 'this'
 	 */
 	public PackedArrayPoint2D_I16 setTo( PackedArrayPoint2D_I16 src ) {
-		reset();
-		reserve(src.size());
-		src.forIdx(0, src.size(), ( idx, p ) -> append(p.x, p.y));
+		array.setTo(src.array);
 		return this;
 	}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedArrayPoint2D_I32.java

@@ -21,6 +21,7 @@
 import boofcv.misc.BoofLambdas;
 import boofcv.struct.PackedArray;
 import georegression.struct.point.Point2D_I32;
+import lombok.Getter;
 import org.ddogleg.struct.DogArray_I32;
 
 /**
@@ -31,10 +32,11 @@
 public class PackedArrayPoint2D_I32 implements PackedArray<Point2D_I32> {
 	private static final int DOF = 2;
 
-	// Stores tuple in a single continuous array
-	public final DogArray_I32 array;
+	/** Stores tuple in a single continuous array */
+	@Getter private final DogArray_I32 array;
+
 	// tuple that the result is temporarily written to
-	public final Point2D_I32 temp = new Point2D_I32();
+	private final Point2D_I32 temp = new Point2D_I32();
 
 	public PackedArrayPoint2D_I32() {
 		array = new DogArray_I32();
@@ -108,9 +110,7 @@ public final void append( int x, int y ) {
 	 * @return Reference to 'this'
 	 */
 	public PackedArrayPoint2D_I32 setTo( PackedArrayPoint2D_I32 src ) {
-		reset();
-		reserve(src.size());
-		src.forIdx(0, src.size(), ( idx, p ) -> append(p.x, p.y));
+		array.setTo(src.array);
 		return this;
 	}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedArrayPoint3D_F64.java

@@ -21,6 +21,7 @@
 import boofcv.misc.BoofLambdas;
 import boofcv.struct.PackedArray;
 import georegression.struct.point.Point3D_F64;
+import lombok.Getter;
 import org.ddogleg.struct.DogArray_F64;
 
 /**
@@ -31,10 +32,11 @@
 public class PackedArrayPoint3D_F64 implements PackedArray<Point3D_F64> {
 	private static final int DOF = 3;
 
-	// Stores tuple in a single continuous array
-	public final DogArray_F64 array;
+	/** Stores tuple in a single continuous array */
+	@Getter private final DogArray_F64 array;
+
 	// tuple that the result is temporarily written to
-	public final Point3D_F64 temp = new Point3D_F64();
+	private final Point3D_F64 temp = new Point3D_F64();
 
 	public PackedArrayPoint3D_F64() {
 		array = new DogArray_F64();
@@ -118,9 +120,7 @@ public void append( double x, double y, double z) {
 	 * @return Reference to 'this'
 	 */
 	public PackedArrayPoint3D_F64 setTo( PackedArrayPoint3D_F64 src ) {
-		reset();
-		reserve(src.size());
-		src.forIdx(0, src.size(), ( idx, p ) -> append(p.x, p.y, p.z));
+		array.setTo(src.array);
 		return this;
 	}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedArrayPoint4D_F64.java

@@ -21,6 +21,7 @@
 import boofcv.misc.BoofLambdas;
 import boofcv.struct.PackedArray;
 import georegression.struct.point.Point4D_F64;
+import lombok.Getter;
 import org.ddogleg.struct.DogArray_F64;
 
 /**
@@ -31,10 +32,11 @@
 public class PackedArrayPoint4D_F64 implements PackedArray<Point4D_F64> {
 	private static final int DOF = 4;
 
-	// Stores tuple in a single continuous array
-	public final DogArray_F64 array;
+	/** Stores tuple in a single continuous array */
+	@Getter private final DogArray_F64 array;
+
 	// tuple that the result is temporarily written to
-	public final Point4D_F64 temp = new Point4D_F64();
+	private final Point4D_F64 temp = new Point4D_F64();
 
 	public PackedArrayPoint4D_F64() {
 		array = new DogArray_F64();
@@ -125,9 +127,7 @@ public void append( double x, double y, double z, double w ) {
 	 * @return Reference to 'this'
 	 */
 	public PackedArrayPoint4D_F64 setTo( PackedArrayPoint4D_F64 src ) {
-		reset();
-		reserve(src.size());
-		src.forIdx(0, src.size(), ( idx, p ) -> append(p.x, p.y, p.z, p.w));
+		array.setTo(src.array);
 		return this;
 	}
 }

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedBigArrayPoint2D_F64.java

@@ -36,7 +36,7 @@ public class PackedBigArrayPoint2D_F64 implements PackedArray<Point2D_F64> {
 	private final BigDogArray_F64 dog;
 
 	// tuple that the result is temporarily written to
-	public final Point2D_F64 temp = new Point2D_F64();
+	private final Point2D_F64 temp = new Point2D_F64();
 
 	/**
 	 * Constructor where the default is used for all parameters.

main/boofcv-types/src/main/java/boofcv/struct/packed/PackedBigArrayPoint3D_F64.java

@@ -36,7 +36,7 @@ public class PackedBigArrayPoint3D_F64 implements PackedArray<Point3D_F64> {
 	private static final int DOF = 3;
 
 	// tuple that the result is temporarily written to
-	public final Point3D_F64 temp = new Point3D_F64();
+	private final Point3D_F64 temp = new Point3D_F64();
 
 	// Storage for the raw data in an array
 	private final BigDogArray_F64 dog;