Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect ignore files #409

Merged
merged 4 commits into from
Feb 14, 2025
Merged

feat: respect ignore files #409

merged 4 commits into from
Feb 14, 2025

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Dec 20, 2024

What's changed:

  • Now watcher respects .gitignore to exclude paths.
  • Patch logic merged into and unified with notify.

Closes: #403

Cargo.toml Outdated Show resolved Hide resolved
@sabify
Copy link
Contributor Author

sabify commented Feb 5, 2025

@gbj @benwis; Have you been able to review this PR?

@benwis
Copy link
Contributor

benwis commented Feb 14, 2025

@sabify Sorry for the delay, this has some conflicts. The changes as I see them make sense

@benwis
Copy link
Contributor

benwis commented Feb 14, 2025

@sabify If you can resolve the conflicts I'll see about merging this

@sabify
Copy link
Contributor Author

sabify commented Feb 14, 2025

@benwis let's make it work.

Copy link
Contributor

@benwis benwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid change, it'd be nice to give people some way to ignore files, although I'm sure someone in the future will want to include it in git and have cargo-leptos ignore it

@benwis benwis merged commit 0ddfc0e into leptos-rs:main Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo leptos watch: can files be ignored?
2 participants