Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printer for setting config from current #168

Conversation

bolajiwahab
Copy link
Contributor

@bolajiwahab bolajiwahab commented Feb 2, 2025

Fixes #167

Comment on lines -3373 to -3375
else:
raise NotImplementedError("SET statement of kind %s not implemented yet"
% node.kind)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VAR_SET_CURRENT is the last option, so it doesn't make sense leaving this here anymore.

@bolajiwahab
Copy link
Contributor Author

Hi @lelit, could you please approve the test run again?

I am also trying to run the test locally but that is not working out.

@lelit
Copy link
Owner

lelit commented Feb 5, 2025

I am also trying to run the test locally but that is not working out.

Ouch, sorry: maybe I can help, if you tell what is the problem there!

@bolajiwahab
Copy link
Contributor Author

bolajiwahab commented Feb 5, 2025

I am also trying to run the test locally but that is not working out.

Ouch, sorry: maybe I can help, if you tell what is the problem there!

So I did the following:

  1. created an environment
  2. make
  3. make check

I keep running into

from pglast import ast, enums, parse_sql, visitors
E   ModuleNotFoundError: No module named 'pglast'

@lelit
Copy link
Owner

lelit commented Feb 6, 2025

So I did the following:

1. created an environment

2. make

3. make check

Run pip install -e . before point 2, and let me know.

@bolajiwahab
Copy link
Contributor Author

bolajiwahab commented Feb 6, 2025

So I did the following:

1. created an environment

2. make

3. make check

Run pip install -e . before point 2, and let me know.

So I had to go this route:

make build
make
pip install -e .

So it looks like a build is needed before installation.

Tests should be fine now.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v7@eed764e). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v7     #168   +/-   ##
=====================================
  Coverage      ?   99.57%           
=====================================
  Files         ?       22           
  Lines         ?     7222           
  Branches      ?        0           
=====================================
  Hits          ?     7191           
  Misses        ?       31           
  Partials      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lelit
Copy link
Owner

lelit commented Feb 7, 2025

Thank you, I merged your changes.

@lelit lelit closed this Feb 7, 2025
lelit added a commit that referenced this pull request Feb 7, 2025
@bolajiwahab bolajiwahab deleted the SET-configuration_parameter-FROM-CURRENT branch February 7, 2025 13:49
lelit added a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printer for "SET configuration_parameter FROM CURRENT"
3 participants