Stabilize priors #141
Open
Stabilize priors #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 28.55% 28.59% +0.03%
==========================================
Files 37 37
Lines 3666 3672 +6
==========================================
+ Hits 1047 1050 +3
- Misses 2619 2622 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theHenks
reviewed
Apr 1, 2025
| @@ -7,11 +7,11 @@ function get_standard_pseudo_prior(h::Histogram, ps::NamedTuple{(:peak_pos, :pea | |||
| μ = ifelse(fixed_position, ConstValueDist(ps.peak_pos), Normal(ps.peak_pos, 0.2*ps.peak_sigma)), | |||
| σ = weibull_from_mx(ps.peak_sigma, 1.5*ps.peak_sigma), | |||
| n = weibull_from_mx(ps.peak_counts, 1.5*ps.peak_counts), | |||
| skew_fraction = ifelse(low_e_tail, truncated(weibull_from_mx(0.002, 0.008), 0.0, 0.5), ConstValueDist(0.0)), | |||
| skew_fraction = ifelse(low_e_tail, truncated(weibull_from_mx(0.002, 0.008), 1e-7, 0.5), ConstValueDist(0.0)), | |||
There was a problem hiding this comment.
Could you quickly explain why 1e-7?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure (log-)density of generated priors is finite over their whole support.