Implemented some fixes

lega0208 · Jul 26, 2024 · 3c7a9df · 3c7a9df
1 parent 3e4018f
commit 3c7a9df
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/libs/upd/i18n/src/lib/translations/en-CA.json b/libs/upd/i18n/src/lib/translations/en-CA.json
@@ -1125,7 +1125,7 @@
   "Overview | Page feedback": "UPD | Overview | Page feedback",
   "Overview | Call drivers": "UPD | Overview | Call drivers",
   "Overview | UX tests": "UPD | Overview | UX tests",
-  "Overview | GC Tasks": "UPD | Overview | GC TASKS",
+  "Overview | GC Tasks": "UPD | Overview | GC tasks",
   "Tasks | Home": "UPD | Tasks | Home",
   "Tasks | Summary": "UPD | Tasks | Summary",
   "Tasks | Web traffic": "UPD | Tasks | Web traffic",

diff --git a/libs/upd/views/projects/src/lib/project-details/+state/projects-details.facade.ts b/libs/upd/views/projects/src/lib/project-details/+state/projects-details.facade.ts
@@ -800,7 +800,6 @@ export class ProjectsDetailsFacade {
       return totalUsers;
 
         },
-        // {} as Record<string, number>,
       )
   );
 

diff --git a/libs/upd/views/tasks/src/lib/task-details/+state/tasks-details.facade.ts b/libs/upd/views/tasks/src/lib/task-details/+state/tasks-details.facade.ts
@@ -678,7 +678,6 @@ export class TasksDetailsFacade {
     map((data) => {
       const uxTests = data?.taskSuccessByUxTest || [];
 
-      // Initialize accumulators for validation and non-validation tests
       const maxTotalUsersByValidation = uxTests.reduce<Record<string, number>>(
         (acc, test) => {
           if (test.test_type === 'Validation') {
@@ -704,12 +703,6 @@ export class TasksDetailsFacade {
         },
         {},
       );
-
-      // Log the maxTotalUsersByTitle for debugging
-      console.log('maxTotalUsersByValidation:', maxTotalUsersByValidation);
-      console.log('maxTotalUsersByNonValidation:', maxTotalUsersByNonValidation);
-
-      // Calculate and sum the total users for both categories
       const validationSum = Object.values(maxTotalUsersByValidation).reduce(
         (sum, val) => sum + val,
         0,
@@ -720,7 +713,6 @@ export class TasksDetailsFacade {
         0,
       );
 
-      // Return the combined sum of both accumulators
       return validationSum + nonValidationSum;
     }),
   );
-Original file line number
+Diff line change
@@ Expand Up / @@ -800,7 +800,6 @@ export class ProjectsDetailsFacade { @@
           return totalUsers;
             },
-            // {} as Record<string, number>,
           )
       );
@@ Expand Down @@