Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical regressions with version 1.11.0.8 #1098

Open
danfe opened this issue Nov 29, 2024 · 4 comments
Open

Graphical regressions with version 1.11.0.8 #1098

danfe opened this issue Nov 29, 2024 · 4 comments

Comments

@danfe
Copy link

danfe commented Nov 29, 2024

Launching the classic Uchibo line, I see the differences compared to 1.11.0.6 and earlier versions: DPI is wrong (font is now too big and does not quite fit the interface elements of the dashboard skin) and no paper table on the right, as shown on the screenshots below. This is on FreeBSD/X11.

1.11.0.6 vs 1.11.0.8

uchibo-1.11.0.6

uchibo-1.11.0.8

@leezer3
Copy link
Owner

leezer3 commented Nov 29, 2024

OK, that's interesting.

Are you running a non 1.0 desktop DPI?
The changes were tested on Windows and Apple, but I don't have an immediate FreeBSD test box.

The basic change likely to be causing this is that it was changed to multiply the default font size in points by the reported desktop scale factor to give a sensible size on stuff with higher factors.

I don't think anything was changed regarding the timetable position off the top of my head, but there's the possibility it's relying on a text size to calculate the position. I'll try and investigate that one.


First (stupid?) question:
I take it the 'new' increased font size is now too big?
This is currently intentional, but might need tweaking at smaller render sizes, but see also my other questions :)

Second:
You're running a 900x600 window render size assuming you haven't resized the images to upload, but how does that relate to your desktop resolution please?

Third:
If you use a larger render size, do things then look better?

@danfe
Copy link
Author

danfe commented Nov 29, 2024

Are you running a non 1.0 desktop DPI?

No, it should be pretty standard one, I don't even have an xorg.conf file:

$ xdpyinfo | grep -A2 ^screen
screen #0:
  dimensions:    1920x1080 pixels (508x285 millimeters)
  resolution:    96x96 dots per inch

First (stupid?) question:
I take it the 'new' increased font size is now too big?

Yes. And not just in notification messages, but also as part of the dashboard, e.g. N\N\EMG in the lower left corner now does not quite fit the frame, and the lower right block looks somewhat out of proportion.

Second:
You're running a 900x600 window render size

Right, 960×600 to be exact, here's the portion of my ~/.config/openBVE/Settings/1.5.0/options.cfg file:

[display]
preferNativeBackend = true
mode = window
vsync = true
windowWidth = 960
windowHeight = 600
fullscreenWidth = 1024
fullscreenHeight = 768

assuming you haven't resized the images to upload,

Oh, no I didn't resize anything. I remember switching from fullscreen to windowed mode some time ago, but cannot recall the exact reason.

but how does that relate to your desktop resolution please?

I've quoted the relevant xdpyinfo(1) output above. :-)

Third:
If you use a larger render size, do things then look better?

I've switched to fullscreen at native 1080p just now, but it didn't help: no timetable on the right and the fonts are still too big.

@leezer3
Copy link
Owner

leezer3 commented Nov 29, 2024

OK, thanks.

This is where we calculate the display scaling:
https://github.com/leezer3/opentk/blob/426814bb50194f48b0f78698555231b6ed328cdc/src/OpenTK/Platform/X11/X11DisplayDevice.cs#L179-L186

Running those values through for your native 1080p gives me a correct 1.0, 1.0 DPI.

I'm trying to setup a FreeBSD vm at the minute.

@leezer3
Copy link
Owner

leezer3 commented Nov 29, 2024

Hmm...

My VM doesn't reproduce:
freebsd
freebsd2

(It's got some pretty nasty keyboard lag, but I think that's just VMWare)

I just installed xorg + xfce and left pretty much everything else at the defaults from the PKGs.
I can dump my complete xorg conf file if you want, but the screen info is this:
(no idea why it decided on that resolution, that was just what the auto-detect decided on)

screen #0:
  dimensions:    1176x885 pixels (311x234 millimeters)
  resolution:    96x96 dots per inch

Is windowed mode any better?
I can't see that it would be, but I'm trying to cover the bases here.


At the minute, it looks like something related to your xorg configuration is causing the detected DPI to be wrong.
I'm by no means an expert on that unfortunately.

If you share some more details of your setup, and probably the complete xorg configuration, I can try and reproduce, but there are all manner of things that could be confusing stuff....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants