All tests are passing except terachem/qmmm #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, LGTM. :) |
|
Do we need to do something to get terachem QM/mm working? Let me know!ToddSent from my iPhoneOn Jan 16, 2025, at 10:49 PM, Lee-Ping Wang ***@***.***> wrote:
Merged #214 into master.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Hi Dr. Martinez,
Thank you for offering to help. I believe the unit tests for Terachem/QMMM
are failing on my workstation because I'm using an older version. I don't
think anything needs to be done on Terachem's side.
…-Heejune Park
On Fri, Jan 17, 2025 at 3:41 AM Todd Martinez ***@***.***>
wrote:
Do we need to do something to get terachem QM/mm working? Let me
know!ToddSent from my iPhoneOn Jan 16, 2025, at 10:49 PM, Lee-Ping Wang
***@***.***> wrote:
Merged #214 into master.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you are subscribed to this thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANC7QQ2CMUQQYWL5FAFDW5T2LDT5DAVCNFSM6AAAAABVF4EY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGE3TQNBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.