Update flow-remove-types #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New explicit inext object syntax - Test fails: Syntax error
- Most recent (2.120.1) seems to fail on basic class syntax, so opted for 2.119.1
|
From the Travis log, it looks like Any thoughts on how to resolve this? We'd really love to keep using this awesome plugin. Perhaps:
|
|
Hey @leebyron. Any guidance on this issue? Thanks! |
|
Sorry for missing your message above. I think the plan as you outlined it makes sense. Want to include those changes in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup-plugin-flowfails on some new flow syntax. Specifically, it fails on explicit inexact object type syntax (ellipsis in property definitions). Updating to a more recent version offlow-remove-typesfixes the issue.Note:
flow-remove-typesversion 2.120.1 fails on basic class syntax. Seems like that version is not ready for production, yet. Version 2.119.1 works on the updated tests and on our source code.