Use $limitnum argument of get_records_sql to fix the MSSQL syntax issue #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft SQL Server (#101)" This reverts commit 2fa7dc6. The solution to the SQL dialect issue is suboptimal. Moodle’s datalib provides the right means of abstraction to formulate our query without database-specific code. We can use the parameter $limitnum from the method get_records_sql of the class moodle_database.
Use the parameter $limitnum of the get_records_sql method. This provides the means to limit the records to only the first one and is database-agnostic.
bluetom
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#101 proposed a fix for a SQL query that used syntax not known to MSSQL. This fix is not database-agnostic. The present PR provides a database-agnostic solution to the problem.