Create task for initial device provisioning #13102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
rtibbles
requested changes
Feb 21, 2025
| throw new Error('Device provisioning task not found'); | ||
| } | ||
| if (task.status === TaskStatuses.COMPLETED) { | ||
| const facilityId = task.result.facility_id; |
There was a problem hiding this comment.
Add this to the extra_metadata instead, rather than updating the API endpoint to return result.
| @@ -100,6 +100,7 @@ def _job_to_response(self, job): | |||
| "args": job.args, | |||
| "kwargs": job.kwargs, | |||
| "extra_metadata": job.extra_metadata, | |||
| "result": job.result, | |||
There was a problem hiding this comment.
Let's not add this, and just utilize extra_metadata instead.
| provision_device(**provisioning_data) | ||
|
|
||
| schedule_ping() # Trigger telemetry pingback after we've provisioned | ||
|
|
There was a problem hiding this comment.
job = get_current_job()
if job:
job.update_metadata(facility_id=facility.id)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: Welcome modal for LOD and on my own devices not appearing is not a regression from this PR, and its probably related to the same cause as #13071
References
Closes #12753
Reviewer guidance
Play with the setup wizard and check that the device is successfully provisioned for all its variants