Implement manual questions selection workflow #13091
Conversation
github-actions
bot
added
APP: Coach
AlexVelezLl
force-pushed
the
manual-selection-workflow
branch
from
d7b2892 to
0c9f5ee
Compare
Build Artifacts
|
AlexVelezLl
force-pushed
the
manual-selection-workflow
branch
from
0c9f5ee to
95ae8d6
Compare
|
Hi @AlexVelezLl, looks great in general but I have the following questions/notes:
up.to.25.questions.mp4
you-shall-not-pass.mp4 |
|
Hi @pcenov. Just looked at the figma again and yes, it was an overlooked on our part, we didnt notice the disabled text input. And yes, point 2 wont be an issue after fixing point 1. Will work on this, thanks! |
|
Hey @pcenov, I just pushed some changes for this, could you take another look, please? 👐 |
There was a problem hiding this comment.
This looks so great @AlexVelezLl and @ozer550! Thanks for the team effort here. I added just a few comments, but nothing blocking. Since I'm a little less focused today, I want to do one final read through before I approve on Monday, just for the sake of being thorough, but I don't anticipate any issues coming up and I think we'll be able to get this merged early on Monday. Thanks again!
| workingQuestions.value = uniqWith([...workingQuestions.value, ...questions], isEqual); | ||
| if (!workingResourcePool.value.find(r => r.id === resource.id)) { | ||
| addToWorkingResourcePool([resource]); |
There was a problem hiding this comment.
So this is, for now, how we are managing having "replacement questions" in the resource pool, right? For question swapping?
| ? selectQuiz$() | ||
| : addNumberOfQuestions$({ count: Math.max(1, settings.questionCount) }) | ||
| " | ||
| :text="saveButtonLabel" |
There was a problem hiding this comment.
such a nice small cleanup 😅
| @@ -131,10 +132,13 @@ | |||
| props.setContinueAction(null); | |||
| }); | |||
|
|
|||
| const questionCountIsEditable = computed(() => !props.settings.isChoosingManually); | |||
There was a problem hiding this comment.
This is non-blocking, but I'm having a little difficulty wrapping my head around what the question count being editable means here. Why would not choosing manually impact the user's ability to adjust the number of questions? It probably makes sense, and I know that there are only so many variable name possibilities. I'm just a but stuck trying to reason through the relationship here
Summary
Compartir.pantalla.-.2025-02-18.12_51_12.mp4
References
Closes #13034
Reviewer guidance
Note
This PR isnt introducing yet the "switching modes" logic. So any flow that involves swiching modes from manual selection to random selection will have an inconsistent behaviour.