Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing facility_name in facility removal notification #13050

Conversation

nucleogenesis
Copy link
Member

Summary

The facility_name was reported missing from the snackbar notification for facility removal, fixed with minor update.

References

Closes #13048

Reviewer guidance

  • Create a facility
  • Remove that facility
  • Do you see the facility's name in the snackbar notification?

@nucleogenesis nucleogenesis requested a review from pcenov February 4, 2025 23:37
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Feb 4, 2025
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nucleogenesis - I confirm that the facility name is displayed correctly now.

@nucleogenesis nucleogenesis merged commit d531917 into learningequality:develop Feb 5, 2025
37 checks passed
@nucleogenesis nucleogenesis deleted the fix--removed-title-missing branch February 5, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device > Facilities - The name of the removed facility is not shown in the snackbar confirmation message
2 participants