Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to preview selected exercise #13032

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ref, getCurrentInstance } from 'vue';
import { ref, getCurrentInstance, computed } from 'vue';
import ContentNodeResource from 'kolibri-common/apiResources/ContentNodeResource';
import { exerciseToQuestionArray } from '../utils/selectQuestions';

export default function useFetchContentNode(contentId) {
const contentNode = ref({});
Expand Down Expand Up @@ -30,12 +31,15 @@ export default function useFetchContentNode(contentId) {
});
};

const exerciseQuestions = computed(() => exerciseToQuestionArray(contentNode.value));

fetchContentNode();

return {
loading,
ancestors,
contentNode,
questions,
exerciseQuestions,
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<div class="questions-accordion-header">
<div>
<KCheckbox
v-if="isSelectable"
ref="selectAllCheckbox"
class="select-all-box"
:label="selectAllLabel$()"
Expand Down Expand Up @@ -58,7 +59,7 @@
}"
>
<template #leading-actions>
<DragHandle>
<DragHandle v-if="isSelectable">
<div>
<DragSortWidget
:moveUpText="upLabel$"
Expand All @@ -72,6 +73,7 @@
</div>
</DragHandle>
<KCheckbox
v-if="isSelectable"
class="accordion-item-checkbox"
:checked="selectedQuestions.includes(question.item)"
@change="
Expand Down Expand Up @@ -168,7 +170,8 @@
},
selectedQuestions: {
type: Array,
required: true,
required: false,
default: () => [],
},
selectAllIsChecked: {
type: Boolean,
Expand All @@ -178,6 +181,11 @@
type: Boolean,
required: false,
},
isSelectable: {
type: Boolean,
required: false,
default: true,
},
},
methods: {
handleDragStart() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,55 +1,6 @@
<template>

<div>
<div class="channel-header">
<p>
{{ coreString('selectFromChannels') }}
</p>

<div class="d-flex-center">
<span
v-if="isSelected"
class="mr-16"
>
<KIcon icon="onDevice" />
{{ addedIndicator$() }}
</span>

<KButton
v-if="isSelected"
:text="coreString('removeAction')"
:primary="true"
:disabled="isActionDisabled"
@click="removeResource()"
/>
<KButton
v-else
:text="addText$()"
:primary="false"
:disabled="isActionDisabled"
@click="addResource()"
/>
</div>
</div>

<ResourceSelectionBreadcrumbs
v-if="ancestors.length"
:ancestors="[...ancestors, currentContentNode]"
:channelsLink="channelsLink"
:topicsLink="topicsLink"
/>

<h2>
<KLabeledIcon :label="currentContentNode.kind">
<template #icon>
<LearningActivityIcon :kind="learningActivities" />
</template>
<template>
{{ currentContentNode.title }}
</template>
</KLabeledIcon>
</h2>

<ContentArea
:header="questionLabel(selectedQuestionIndex)"
:selectedQuestion="selectedQuestion"
Expand Down Expand Up @@ -104,13 +55,8 @@
import { searchAndFilterStrings } from 'kolibri-common/strings/searchAndFilterStrings';
import { licenseLongName } from 'kolibri/uiText/licenses';
import markdownIt from 'markdown-it';
import { ContentNodeKinds } from 'kolibri/constants';
import LearningActivityIcon from 'kolibri-common/components/ResourceDisplayAndSearch/LearningActivityIcon.vue';
import SlotTruncator from 'kolibri-common/components/SlotTruncator';
import { SelectionTarget } from '../../contants.js';
import { PageNames } from '../../../../../constants/index.js';
import ContentArea from '../../../../lessons/LessonSelectionContentPreviewPage/LessonContentPreview/ContentArea.vue';
import ResourceSelectionBreadcrumbs from '../../../../lessons/LessonResourceSelectionPage/SearchTools/ResourceSelectionBreadcrumbs.vue';
import HeaderTable from '../../../HeaderTable/index.vue';
import HeaderTableRow from '../../../HeaderTable/HeaderTableRow.vue';

Expand All @@ -121,25 +67,15 @@
HeaderTable,
HeaderTableRow,
SlotTruncator,
LearningActivityIcon,
ResourceSelectionBreadcrumbs,
},
mixins: [commonCoreStrings],
setup() {
const {
addText$,
copyrightHolderDataHeader$,
licenseDataHeader$,
addedIndicator$,
notAvailableLabel$,
minutes$,
} = searchAndFilterStrings;
const { copyrightHolderDataHeader$, licenseDataHeader$, notAvailableLabel$, minutes$ } =
searchAndFilterStrings;

return {
addText$,
licenseDataHeader$,
copyrightHolderDataHeader$,
addedIndicator$,
notAvailableLabel$,
minutes$,
};
Expand All @@ -149,31 +85,13 @@
type: Object,
required: true,
},
ancestors: {
type: Array,
required: false,
default: () => [],
},
isSelected: {
type: Boolean,
required: true,
},
questions: {
type: Array,
required: false,
default: () => [],
},
isActionDisabled: {
isExercise: {
type: Boolean,
required: false,
default: false,
},
/**
* The target entity for the selection.
* It can be either 'quiz' or 'lesson'.
*/
target: {
type: String,
required: true,
},
},
Expand All @@ -183,17 +101,6 @@
};
},
computed: {
channelsLink() {
return {
name:
this.target === SelectionTarget.LESSON
? PageNames.LESSON_SELECT_RESOURCES_INDEX
: PageNames.QUIZ_SELECT_RESOURCES_INDEX,
};
},
isExercise() {
return this.currentContentNode.kind === ContentNodeKinds.EXERCISE;
},
selectedQuestion() {
if (this.isExercise) {
return this.questions[this.selectedQuestionIndex];
Expand All @@ -211,42 +118,15 @@

return undefined;
},
learningActivities() {
if (this.currentContentNode.learning_activities) {
return this.currentContentNode.learning_activities;
}
return [];
},
},
methods: {
topicsLink(topicId) {
const { params, query } = this.$route;

return {
name:
this.target === SelectionTarget.LESSON
? PageNames.LESSON_SELECT_RESOURCES_TOPIC_TREE
: PageNames.QUIZ_SELECT_RESOURCES_TOPIC_TREE,
params: params,
query: {
...query,
topicId,
},
};
},
questionLabel(questionIndex) {
if (!this.isExercise) {
return '';
}
const questionNumber = questionIndex + 1;
return this.coreString('questionNumberLabel', { questionNumber });
},
addResource() {
this.$emit('addResource', this.currentContentNode);
},
removeResource() {
this.$emit('removeResource', this.currentContentNode);
},
getTime(seconds) {
return this.minutes$({ value: Math.floor(seconds / 60) });
},
Expand All @@ -258,15 +138,6 @@

<style lang="scss" scoped>

.mr-16 {
margin-right: 16px;
}

.d-flex-center {
display: flex;
align-items: center;
}

.license-detail-style {
margin-top: 10px;
}
Expand All @@ -276,14 +147,4 @@
max-height: 500px;
}

.channel-header {
display: flex;
align-items: center;
justify-content: space-between;
}

.channel-header p {
font-weight: 600;
}

</style>
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<template>

<div>
<QuestionsAccordion
:questions="questions"
:getQuestionContent="() => contentNode"
:isSelectable="false"
/>
</div>

</template>


<script>

import QuestionsAccordion from '../../../QuestionsAccordion.vue';

export default {
name: 'PreviewExercise',
components: {
QuestionsAccordion,
},

props: {
contentNode: {
type: Object,
required: true,
},
questions: {
type: Array,
required: true,
},
},
};

</script>
Loading
Loading