Adds ability to preview selected exercise #13032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AllanOXDi
force-pushed
the
preview-selected-exercise
branch
from
c4ea2bf to
1ca1517
Compare
AllanOXDi
changed the title
AlexVelezLl
previously requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks @AllanOXDi! This is looking great! I have left just some comments and a little regression I found. Please let me know if you have any question! 👐
kolibri/plugins/coach/assets/src/composables/useFetchExercise.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/common/QuestionsAccordion.vue
Outdated
Show resolved
Hide resolved
...onSummaryPage/sidePanels/LessonResourceSelection/subPages/PreviewSelectedResources/index.vue
Outdated
Show resolved
Hide resolved
...Panels/LessonResourceSelection/subPages/PreviewSelectedResources/PreviewSelectedExercise.vue
Outdated
Show resolved
Hide resolved
...Panels/LessonResourceSelection/subPages/PreviewSelectedResources/PreviewSelectedExercise.vue
Outdated
Show resolved
Hide resolved
...Panels/LessonResourceSelection/subPages/PreviewSelectedResources/PreviewSelectedExercise.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/common/QuestionsAccordion.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
whoops, it looks like @AlexVelezLl and I were reviewing at the same time to a few duplicate comments! Overall this is looking good @AllanOXDi and I think with a little bit of polishing up it will be ready to go soon :)
kolibri/plugins/coach/assets/src/composables/useFetchExercise.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/common/QuestionsAccordion.vue
Outdated
Show resolved
Hide resolved
AllanOXDi
force-pushed
the
preview-selected-exercise
branch
from
36157e7 to
38ddfd7
Compare
AlexVelezLl
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Thanks @AllanOXDi!! Code looks good and didnt found anything else while manual QA. LGTM! :). Will let the final approve to @marcellamaki 🤗
marcellamaki
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12989
Screen.Recording.2025-01-28.at.15.02.50.mov
References
#12989
…
Reviewer guidance
See this
Navigate through the lesson workflow using the /lessonstemp path.
Can you successfully preview any exercise from the side pane ?
Is the side panel mobile responsiveness and a11y?