Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left side of focus ring around KButton in Device permissions is cut off #9177

Open
sairina opened this issue Mar 14, 2022 · 1 comment
Open

Left side of focus ring around KButton in Device permissions is cut off #9177

sairina opened this issue Mar 14, 2022 · 1 comment
Labels
P2 - normal Priority: Nice to have
Milestone
upcoming patch

Comments

@sairina
Copy link
Contributor

sairina commented Mar 14, 2022

Observed behavior

Left side of focus ring around KButton in Device permissions is cut off
Screen Shot 2022-03-14 at 8 22 47 AM

Errors and logs

None

Expected behavior

The full focus ring around the button should be visible

User-facing consequences

It does not match the other instances of KButton

Steps to reproduce

  1. Sign in as admin
  2. In "Device" click on the "Permissions" tab
  3. Use keyboard navigation throughout the "Permissions" tab

Context

Kolibri 0.15
MacOS
Chrome
@sairina sairina mentioned this issue Mar 14, 2022
Closed
@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression and removed P0 - critical Priority: Release blocker or regression labels Apr 28, 2022
@marcellamaki marcellamaki modified the milestones: Planned Patch 2: Content and a11y, Planned Patch 3: TBD Apr 28, 2022
@marcellamaki marcellamaki modified the milestones: Planned Patch 4: Coach usability improvements, Content Updates to support 0.16 Jun 22, 2022
@marcellamaki marcellamaki added the P2 - normal Priority: Nice to have label Jun 28, 2022
@Abhishek-Punhani
Copy link
Contributor

Hi @sairina,

I was reviewing this issue, but I am able to see the full focus ring while navigating the page with the keyboard on both Chrome and Firefox. Could you provide more details or guide me on reproducing the issue?

Thanks!

Screencast.from.02-22-2025.04.27.50.PM.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 - normal Priority: Nice to have
Projects
None yet
Milestone
upcoming patch
Development

No branches or pull requests
3 participants
@sairina @marcellamaki @Abhishek-Punhani