Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for the useQuizResources module #12033

Open
3 tasks
Tracked by #11741
nucleogenesis opened this issue Mar 28, 2024 · 8 comments
Open
3 tasks
Tracked by #11741

Write tests for the useQuizResources module #12033

nucleogenesis opened this issue Mar 28, 2024 · 8 comments
Assignees
Labels
help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented Mar 28, 2024

Overview

The quiz creation updates added a new useQuizResources module that extends an also-new useFetchTree module. useFetchTree has tests written for it but useQuizResources does not.

Acceptance criteria

There is no real need to test that the useFetchTree modules do what they're supposed to so they can likely just be mocked to return a suitable data structure.

@oge1ata
Copy link
Contributor

oge1ata commented Apr 15, 2024

Hi @nucleogenesis could I take a look at this isuse?

@MisRob
Copy link
Member

MisRob commented Apr 16, 2024

Hi @oge1ata, thank you for volunteering, looking at the issue I think this could be open for contribution. It may help to spend some time looking at existing test suites, such as useFetchTree that @nucleogenesis referenced.

@oge1ata
Copy link
Contributor

oge1ata commented Apr 17, 2024

Hey @MisRob Thanks for the assignment. I'd take a look at it and tell you if I have any issues.

@MisRob
Copy link
Member

MisRob commented Jun 11, 2024

Hi @oge1ata, are you still planning to work in this?

@GautamBytes
Copy link
Contributor

Hi @marcellamaki , I would like to contribute to this issue , can you assign me this?
Thanks!

@LianaHarris360
Copy link
Member

Hi @GautamBytes thanks for volunteering to fix this issue! I'll go ahead and assign this to you. Please let us know if you have any questions or need clarification on anything.

@GautamBytes
Copy link
Contributor

Hey @LianaHarris360 and @nucleogenesis , I have created a PR addressing this issue , it passes all the test cases as mentioned in issue . You can have a look and suggest some improvements wherever needed.Thanks!

@MisRob
Copy link
Member

MisRob commented Feb 17, 2025

Thanks @GautamBytes, we will review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

7 participants