-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for the useQuizResources
module
#12033
Comments
Hi @nucleogenesis could I take a look at this isuse? |
Hi @oge1ata, thank you for volunteering, looking at the issue I think this could be open for contribution. It may help to spend some time looking at existing test suites, such as |
Hey @MisRob Thanks for the assignment. I'd take a look at it and tell you if I have any issues. |
Hi @oge1ata, are you still planning to work in this? |
Hi @marcellamaki , I would like to contribute to this issue , can you assign me this? |
Hi @GautamBytes thanks for volunteering to fix this issue! I'll go ahead and assign this to you. Please let us know if you have any questions or need clarification on anything. |
Hey @LianaHarris360 and @nucleogenesis , I have created a PR addressing this issue , it passes all the test cases as mentioned in issue . You can have a look and suggest some improvements wherever needed.Thanks! |
Thanks @GautamBytes, we will review. |
Overview
The quiz creation updates added a new
useQuizResources
module that extends an also-newuseFetchTree
module.useFetchTree
has tests written for it butuseQuizResources
does not.Acceptance criteria
There is no real need to test that the
useFetchTree
modules do what they're supposed to so they can likely just be mocked to return a suitable data structure.annotateTopicsWithDescendantCounts
-- see the comment above it to get a sense for what is supposed to be happening here.fetchQuizResources
andfetchMoreQuizResources
functionsThe text was updated successfully, but these errors were encountered: