Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac app and Safari - Minor design issue in the Users table #11789

Open
pcenov opened this issue Jan 25, 2024 · 11 comments
Open

Mac app and Safari - Minor design issue in the Users table #11789

pcenov opened this issue Jan 25, 2024 · 11 comments
Labels
APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend OS: Mac P2 - normal Priority: Nice to have safari Limited to safari or webkit

Comments

@pcenov
Copy link
Member

pcenov commented Jan 25, 2024

Observed behavior

Observed while regression testing the Mac app but also valid when Kolibri is opened in Safari 17.2.1.

2024-01-25_11-58-37

Expected behavior

The strange gray item should not be visible in the 'Full name' column

Steps to reproduce the issue

  1. Install the latest Beta 13 Mac app.
  2. Setup a full facility and go to Facility > Users
  3. Create a new user and look at the 'Full name' column

Usage Details

Beta 13
Ubuntu 22 - Chrome

@pcenov
Copy link
Member Author

pcenov commented Jan 25, 2024

@radinamatic

@radinamatic radinamatic added P2 - normal Priority: Nice to have OS: Mac APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) safari Limited to safari or webkit DEV: frontend labels Jan 25, 2024
@varshith257
Copy link

@radinamatic I would like to work on it. Can you assign me this issue?

@AlexVelezLl
Copy link
Member

Hi @varshith257! Thank you for your interest in contributing to Kolibri! I will assign this issue to you! Let us know if you have any questions 🤗

@MisRob
Copy link
Member

MisRob commented Feb 12, 2025

(1) This table in Users -> Facility is now replaced by KTable (#13028) so for this particular place, first step here would be to see if this is still happening.

(2) However UserTable component where this issue occured is still used in many other places, so even if (1) is not problem anymore, it could still be present elsewhere.

@GautamBytes
Copy link
Contributor

Hey @MisRob , asking just out of curiosity , Since the issue is specific to Mac/Safari and doesn't appear in Ubuntu-Chrome, I wanted to confirm:

  • Would I be able to effectively contribute to this issue without having direct access to a Mac?
  • If yes, what would be the recommended approach for testing my changes since I can't directly replicate the issue?"

@marcellamaki
Copy link
Member

Hi @GautamBytes - thanks for your interest. I think it would be best to choose another issue because the first step of this is about replicating on Safari, and then debugging from there.

@GautamBytes
Copy link
Contributor

Okay sure @marcellamaki , thank you!

@SukhvirKooner
Copy link

SukhvirKooner commented Feb 14, 2025

Hi, @MisRob

  • I’d love the opportunity to work on this issue, as I have access to a Mac and can thoroughly test the behavior in both the Mac app and Safari 17.2.1.
  • If possible, could you kindly assign me to this issue?
  • Please let me know if there are any specific aspects I should focus on.

@MisRob
Copy link
Member

MisRob commented Feb 17, 2025

Thanks @SukhvirKooner, I will assign you. I left some guidance here.

@SukhvirKooner
Copy link

Hi @MisRob,
This issue is not valid, as the file is working correctly on the develop branch. As already discussed with @rtibbles, this issue can be closed.

Image

@rtibbles rtibbles removed the help wanted Open source contributors welcome label Feb 21, 2025
@rtibbles
Copy link
Member

Thanks @SukhvirKooner - I'll ask @pcenov to verify and then we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend OS: Mac P2 - normal Priority: Nice to have safari Limited to safari or webkit
Projects
None yet
Development

No branches or pull requests

9 participants