feat: add param values to request()
params
#286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add param values to
request()
paramsWhat kind of change does this PR introduce? (pls check at least one)
Description
This PR enhances the
findRoute
method to properly extract and merge dynamic route parameters into the$_GET
superglobal. Previously, dynamic parameters were not accessible via request handlers if query parameters were present in the URL. This update ensures:{param}
) in the route pattern are captured and assigned to$_GET
.i.e the parameter value for a route like
/user/{id}
will also be available as$_GET['id']
orrequest()->params('id)
./
) are trimmed correctly.varN
for unnamed segments).This improvement provides better consistency for accessing request parameters within route handlers.
Does this PR introduce a breaking change? (check one)