fix: vite optimize deps usage and production build when using a workspace #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues around how the framework uses Vite deps optimizer in development mode.
To support production builds in a workspace, this PR needed to provide a workaround to prevent files outside of the current working directory to output assets outside of the build target directory by replacing relative path fragments.
Cache directories are moved outside of
.react-serverintonode_modules/.react-serverso a production build is not destroying a previous development mode cache directory.Fixes a small client-side navigation issue when using browser back/forward.
This extends the Mantine example to include:
recharts@2works!)With this PR the framework now should support requirements specified in #20.