Automatic module detection only finds modules #370
Conversation
| function listmodules() | ||
| local function listmodules() |
There was a problem hiding this comment.
I think this needs to be available generally - one might want it in custom build.lua code
There was a problem hiding this comment.
I made it local because it was not documented in l3build.dtx.
Is it already used? by LaTeX?
As global function the name is not appropriate, imagine the documentation
listmodules(): automatically detects module
instead of
detectedmodules(): list of automatically detected module
Decision required.
There was a problem hiding this comment.
What's wrong with listmodule() - it returns a list of modules.
There was a problem hiding this comment.
listmodules can be interpreted as a function that "list modules", a function that returns modules about list, a function that returns a "list of modules".
| for entry in tree(".", "*/build.lua") do -- TODO: support "**/..." | ||
| local module = dirname(entry.cwd) | ||
| if #module > 2 then -- this is not the current directory | ||
| module = module:sub(3) -- remove the leading "./" | ||
| if not exclmodules[module] then | ||
| insert(modules, module) |
There was a problem hiding this comment.
I don't follow - aren't you risking having unpredictable nesting levels?
There was a problem hiding this comment.
No, "*/..." only looks at the first level contrary to "**/..." that looks at arbitrary depth
There was a problem hiding this comment.
Ah, right, yes.
So wider question is why not just add to exclmodules as in my suggestion - minimal change and all that.
listmodulesis turned local.It looks for any
build.luain subdirectories at depth 1.