-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stick to third-person singular form in target and option docs #340
Stick to third-person singular form in target and option docs #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three(?) places “and exit.” should become “and exits.”
Similarly, “simply rerun tests” probably should become “… reruns …”
Aside: I cannot parse this sentence: … to … to … ?? —
Applies the Lua |update_tag()| function to modify the contents of files specified by |tagfiles| to update the `release tag' (or package version) and date.
Aside: Should this have been: … run, even if … —
Forces tests to run if engine is not set up
Co-authored-by: Chris Rowley <latex-bugs@latex-project.org>
Co-authored-by: Chris Rowley <latex-bugs@latex-project.org>
Hmm the "Co-authored-by" trailers in git commit messages don't work as expected. |
We good to go here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me (but what do I know :-) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay.
I am not familiar with “assertions”, or the way that they are normally defined or described.
But the ”assert” here looks strange here! “true if . . . “ would be normal English:
assert if the full expansion of \meta{arg_1} and \meta{arg_2} are the same:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 594-6.
I think that the following is much clearer (if accurate:-) :
Applies the Lua |update_tag()| function to modify the contents of
all the filesspecified by |tagfiles|:
this function updates the `release tag' (or package version)
and date.
@josephwright (I guess). The major problem with the \ASSERT item in this list is that it does not say anything about what actually gets written to the log file. Thus it seems to need a total rewrite. |
@car222222 Well perhaps but that's a separate issue - suggest we agree on the PR here then I re-work that sentence later. |
@josephwright Agreed that this is something else again! |
My comment on Lines 594-6 got mangled a bit, try this instead. Applies the Lua |update_tag()| function |
@car222222 Added as 0231d16 |
|
I think that a space got lost in 0231d16, should be "; this". Probably my fault. |
Introduced in 0231d16 (Update from Chris, 2024-01-11) and pointed out by Chris in latex3#340 (comment).
Introduced in 0231d16 (Update from Chris, 2024-01-11) and pointed out by Chris in #340 (comment).
No description provided.