Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Give users the option to keep js/css when installing the API stack #450

Closed
wants to merge 1 commit into from

Conversation

paulrose
Copy link

Give users the option to keep js/css when installing the API stack.

For example, it's often a case where I'll want to add Auth features, but I've already started working on my frontend, I just don't want to implement the full Breeze stack for whatever reason.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@paulrose
Copy link
Author

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@taylorotwell, While I appreciate what you're saying, you need to be careful about the amount of code you introduce, I'd ask you to re-think the approach here.

I'm unsure why adding authentication routes would indiscriminately delete a users project files without warning? That feels like bad design. File deletion is not mentioned in the docs at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants