Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] add types to useForm in Login.tsx #446

Conversation

joelbutcher
Copy link
Contributor

This PR adds type definitions to the useForm props in Login.tsx for the React Typescript stack, which fixes the problem with these recent tests failing

@taylorotwell
Copy link
Member

Hey there! We are rebuilding our starter kits now, so will address any needs there. We should have them out in ~4 weeks.

@joelbutcher
Copy link
Contributor Author

Hey @taylorotwell I appreciate that you and the team are shifting focus for starter kits, but in the meantime this is currently causing my test pipelines to fail for Socialstream as I try as best I can to follow the files that are published by Laravel (to avoid making too many changes if someone installs Breeze, commit it, then add Socialstream later in a different commit).

If this is a hard "no", I'll just override this in my packages stub files to get my tests passing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants