Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install issues #57

Open
jjaraalm opened this issue Feb 4, 2021 · 2 comments
Open

make install issues #57

jjaraalm opened this issue Feb 4, 2021 · 2 comments

Comments

@jjaraalm
Copy link
Collaborator

jjaraalm commented Feb 4, 2021

Making binary installations with make install has some issues:

  1. Public header files are not installed
  2. If BUILD_INTERNAL_KOKKOS = ON then the installed compile script references locations in the source and build directories instead of their installed counterparts. (e.g., srcdir/kokkos/bin/nvcc_wrapper instead of installdir/bin/nvcc_wrapper)
@rfbird
Copy link
Contributor

rfbird commented Feb 4, 2021

This is basically not intended to work right now, since no one has looked at it. Everyone this end runs it in place, so we've not spent any effort on it. I take it this means you actually do an install?

We had been waiting for the kokkos cmake changes, which have now happened, so now might make sense as a time to add this

@jjaraalm
Copy link
Collaborator Author

jjaraalm commented Feb 4, 2021

This is not a priority at all for me. I was trying to have multiple branches built using the same repo, but I'm fine with having multiple repos instead. I opened this to capture what I found, but feel free to kick it down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants