Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake configuration and kokkos versions #47

Open
jjaraalm opened this issue Dec 22, 2020 · 5 comments
Open

cmake configuration and kokkos versions #47

jjaraalm opened this issue Dec 22, 2020 · 5 comments

Comments

@jjaraalm
Copy link
Collaborator

Cmake config needs to be updated or tested over different versions

cmake_minimum_required(VERSION 3.9)
cmake_policy(SET CMP0074 NEW)

Policy CMP0074 doesn't exist between 3.9-3.12 and raises an error.

Using -DBUILD_INTERNAL_KOKKOS=ON with a recently updated Kokkos submodule and nvcc 10.2 raises an error that C++14 is required. I had to change to

set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

to make it work.

@jjaraalm
Copy link
Collaborator Author

For the second, I accidentally bumped Kokkos to 3.3.0 and this might be related. It also introduced new half-precision issues related to kokkos/kokkos#3561. I'm reverting back to 3.1.0.

For reference, my toolchain is

  • nvcc 10.2
  • gcc 7.3.1
  • openmpi 3.1

@junghans
Copy link
Member

Heads up kokkos will require cmake-3.17 pretty soon, you might want to move away from travis to github Actions.
see
https://github.com/kokkos/kokkos/blob/develop/.github/workflows/continuous-integration-workflow.yml
the key is to use the ghcr.io/kokkos/ci-containers/${{ matrix.distro }} containers, which has also the packages to build kokkos.

@rfbird
Copy link
Contributor

rfbird commented Dec 22, 2020

Interesting, thanks for that @junghans. I was planning to move us up to 3.3.0 soon and figured a bunch of that out locally yesterday. Seems like a good time to change the CI too

@jjaraalm
Copy link
Collaborator Author

Thanks for the info. It's actually my production system which uses cmake 3.11 by default; just had to change modules. I guess my point was just to make sure minimum version requirements and standards are consistent.

@rfbird
Copy link
Contributor

rfbird commented Dec 22, 2020

Yea I think lets just go to the future early, and move to 3.17 ahead of Kokkos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants