Daniel #89
Merged
Daniel #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause of how we need to update device data
Adrian-Diaz
approved these changes
Jul 29, 2024
| mpi_datatype_ = MPI_DOUBLE; | ||
| } | ||
| else { | ||
| printf("Your entered MPIArrayKokkos type is not a supported type for MPI communications and is being set to int\n"); |
There was a problem hiding this comment.
We should say that it is not supported by Matar, and just refer to where it can be added to avoid emails.
There was a problem hiding this comment.
Would typeid support custom MPI data types?
There was a problem hiding this comment.
it could if it was added in as an option that people wanted. I figured right now there's so few data types we actually need.
There was a problem hiding this comment.
I think they are grouped as they are in the declarations. I'll make sure
| update_host(); | ||
| MPI_Isend(host_pointer(), count, mpi_datatype_, dest, tag, comm, &mpi_request_); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
lets move isend and irecv so its after send and recv for consistent grouping like the halo prototypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Pull Request. This is the pull request with MPI types, but it also has some CMake changes to handle different linking libraries for each example.
Everything built on Darwin with No Kokkos, Serial Kokkos, Cuda Kokkos, and Cuda/MPI Kokkos. Hopefully it works for anyone else trying it out.