Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for JuMP's New NL Interface #901

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Updates for JuMP's New NL Interface #901

merged 4 commits into from
Jan 19, 2024

Conversation

ccoffrin
Copy link
Member

@ccoffrin ccoffrin commented Jan 4, 2024

Remove @NL macros and simplify code that branched on NL vs non-NL models.

@ccoffrin ccoffrin changed the title Updates for JuMPNew NL Interface Updates for JuMP's New NL Interface Jan 4, 2024
@ccoffrin ccoffrin requested a review from odow January 4, 2024 00:53
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a2856d1) 93.98% compared to head (8cea192) 94.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
+ Coverage   93.98%   94.22%   +0.24%     
==========================================
  Files          43       43              
  Lines        9637     9612      -25     
==========================================
  Hits         9057     9057              
+ Misses        580      555      -25     
Files Coverage Δ
src/form/acp.jl 93.23% <100.00%> (-0.48%) ⬇️
src/form/acr.jl 98.47% <100.00%> (-0.04%) ⬇️
src/form/act.jl 95.00% <100.00%> (ø)
src/form/iv.jl 92.66% <100.00%> (ø)
src/core/objective.jl 95.90% <87.50%> (+0.11%) ⬆️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2856d1...8cea192. Read the comment docs.

Copy link
Collaborator

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccoffrin
Copy link
Member Author

ccoffrin commented Jan 4, 2024

I am going to hold merging and tagging for about a week to see if there is any feedback from other package developers.

Copy link
Member Author

@ccoffrin ccoffrin Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow, FYI on this weird Ipopt behavior on Windows in Julia v1.6, https://github.com/lanl-ansi/PowerModels.jl/actions/runs/7587175654/job/20666919070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants