-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for JuMP's New NL Interface #901
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
==========================================
+ Coverage 93.98% 94.22% +0.24%
==========================================
Files 43 43
Lines 9637 9612 -25
==========================================
Hits 9057 9057
+ Misses 580 555 -25
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am going to hold merging and tagging for about a week to see if there is any feedback from other package developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@odow, FYI on this weird Ipopt behavior on Windows in Julia v1.6, https://github.com/lanl-ansi/PowerModels.jl/actions/runs/7587175654/job/20666919070
Remove
@NL
macros and simplify code that branched on NL vs non-NL models.