Skip to content

Commit

Permalink
Update workflows for better test coverage and integration (#2344)
Browse files Browse the repository at this point in the history
* ✨ (typescript_test.yml): add workflow_dispatch event to trigger workflow manually with branch input parameter

🔧 (typescript_test.yml): update workflow to checkout code from the specified branch when triggered manually

* 📝 (lint-py.yml): update linting workflow to trigger on specific pull request events and checks requested action

📝 (lint-py.yml): add a specific job to run Mypy for static type checking in the linting workflow

* 🔧 (python_test.yml): update pull_request event types and branches to trigger on more actions for better test coverage and integration
  • Loading branch information
ogabrielluiz committed Jun 25, 2024
1 parent 791bd70 commit 8ea9542
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 14 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/lint-py.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@ name: Lint Python

on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
- "tests/**"
merge_group:
branches: [dev]

types: [checks_requested]
env:
POETRY_VERSION: "1.8.2"

jobs:
lint:
name: Run Mypy
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -34,6 +35,8 @@ jobs:
run: |
poetry env use ${{ matrix.python-version }}
poetry install
- name: Run Mypy
run: |
make lint
env:
GITHUB_TOKEN: ${{ secrets.github_token }}
13 changes: 4 additions & 9 deletions .github/workflows/python_test.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,21 @@
name: Python tests

on:
push:
branches: [main]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
pull_request:
branches: [dev]
types: [opened, synchronize, reopened]
branches: [dev, main]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
merge_group:
branches: [dev]

types: [checks_requested]
env:
POETRY_VERSION: "1.8.2"

jobs:
build:
name: Run Unit Tests
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/typescript_test.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
name: Run Frontend Tests

on:
pull_request:
paths:
- "src/frontend/**"
workflow_dispatch:
inputs:
branch:
description: "Branch to run tests on"
required: true
type: string


env:
POETRY_VERSION: "1.8.2"
Expand All @@ -15,6 +19,7 @@ env:

jobs:
setup-and-test:
name: Run Frontend Tests on branch ${{ inputs.branch }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand All @@ -24,6 +29,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ inputs.branch }}

- name: Setup Node.js
uses: actions/setup-node@v4
Expand Down

0 comments on commit 8ea9542

Please sign in to comment.