Skip to content

Commit

Permalink
Run msrv check for all crates (open-telemetry#1826)
Browse files Browse the repository at this point in the history
  • Loading branch information
cijothomas authored May 24, 2024
1 parent ac741c2 commit ec9fd62
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,8 @@ jobs:
- uses: dtolnay/rust-toolchain@1.65.0
- name: Patch dependencies versions # some dependencies bump MSRV without major version bump
run: bash ./scripts/patch_dependencies.sh
- name: Run tests
run: cargo --version &&
cargo test --manifest-path=opentelemetry/Cargo.toml --features trace,metrics,testing &&
cargo test --manifest-path=opentelemetry-zipkin/Cargo.toml
- name: Check MSRV for all crates
run: bash ./scripts/msrv.sh
cargo-deny:
runs-on: ubuntu-latest # This uses the step `EmbarkStudios/cargo-deny-action@v1` which is only supported on Linux
continue-on-error: true # Prevent sudden announcement of a new advisory from failing ci
Expand Down
33 changes: 33 additions & 0 deletions scripts/msrv.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#!/bin/bash

set -eu

echo "Running msrv check for opentelemetry package"
cargo check --manifest-path=opentelemetry/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-sdk package"
cargo check --manifest-path=opentelemetry-sdk/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-stdout package"
cargo check --manifest-path=opentelemetry-stdout/Cargo.toml --all-features

# TODO: Ignoring as this is failing with the following error:
# error: package `prost-derive v0.12.6` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0
#echo "Running msrv check for opentelemetry-otlp package"
# cargo check --manifest-path=opentelemetry-otlp/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-http package"
cargo check --manifest-path=opentelemetry-http/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-jaeger-propagator package"
cargo check --manifest-path=opentelemetry-jaeger-propagator/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-zipkin package"
cargo check --manifest-path=opentelemetry-zipkin/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-appender-log package"
cargo check --manifest-path=opentelemetry-appender-log/Cargo.toml --all-features

echo "Running msrv check for opentelemetry-appender-tracing package"
cargo check --manifest-path=opentelemetry-appender-tracing/Cargo.toml --all-features

0 comments on commit ec9fd62

Please sign in to comment.