forked from open-telemetry/opentelemetry-rust
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add External Type Checking (open-telemetry#1603)
The purpose of this is to ensure we understand the API surface area. Anything exposed by a crate like a type can affect the possible compatibility. This means that if we bump an external type it could cause breaking changes. This tracks them to limit this possibility. Affected Crates: opentelemetry-otlp opentelemetry-zipkin
- Loading branch information
Showing
3 changed files
with
35 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# This is used with cargo-check-external-types to reduce the surface area of downstream crates from | ||
# the public API. Ideally this can have a few exceptions as possible. | ||
allowed_external_types = [ | ||
"opentelemetry::*", | ||
"opentelemetry_http::*", | ||
"opentelemetry_sdk::*", | ||
# http is a pre 1.0 crate | ||
"http::uri::InvalidUri", | ||
"http::header::name::InvalidHeaderName", | ||
"http::header::value::InvalidHeaderValue", | ||
# prost is a pre 1.0 crate | ||
"prost::error::EncodeError", | ||
# tonic is a pre 1.0 crate | ||
"tonic::status::Code", | ||
"tonic::status::Status", | ||
"tonic::metadata::map::MetadataMap", | ||
"tonic::transport::channel::Channel", | ||
"tonic::transport::error::Error", | ||
"tonic::service::interceptor::Interceptor", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# This is used with cargo-check-external-types to reduce the surface area of downstream crates from | ||
# the public API. Ideally this can have a few exceptions as possible. | ||
allowed_external_types = [ | ||
"opentelemetry::*", | ||
"opentelemetry_http::*", | ||
"opentelemetry_sdk::*", | ||
# http is a pre 1.0 crate | ||
"http::error::Error", | ||
"http::uri::InvalidUri", | ||
] |