Merge pull request #7 from DandyLyons/main

`Collection` conformance for `LeftValues` and `RightValues`
ladvoc · Sep 8, 2024 · 175cec4 · 175cec4
2 parents 9b84532 + 545481b
commit 175cec4
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 5 deletions.
diff --git a/Sources/BijectiveDictionary/BijectiveDictionary+LeftValues.swift b/Sources/BijectiveDictionary/BijectiveDictionary+LeftValues.swift
@@ -76,8 +76,23 @@ extension BijectiveDictionary.LeftValues: Sequence {
 }
 
 // MARK: - Collection
-
-// TODO: implement collection
+extension BijectiveDictionary.LeftValues: Collection {
+
+    public typealias Index = BijectiveDictionary<Left, Right>.Index
+
+    @inlinable public var startIndex: Index { Index(_ltr.startIndex) }
+    @inlinable public var endIndex: Index { Index(_ltr.endIndex) }
+
+    @inlinable
+    public func index(after i: Index) -> Index {
+        Index(_ltr.index(after: i._ltrIndex))
+    }
+
+    @inlinable
+    public subscript(position: Index) -> Left {
+        _ltr[position._ltrIndex].key
+    }
+}
 
 // MARK: - Other Conformances
 

diff --git a/Sources/BijectiveDictionary/BijectiveDictionary+RightValues.swift b/Sources/BijectiveDictionary/BijectiveDictionary+RightValues.swift
@@ -76,9 +76,23 @@ extension BijectiveDictionary.RightValues: Sequence {
 }
 
 // MARK: - Collection
-
-// TODO: implement collection
-
+extension BijectiveDictionary.RightValues: Collection {
+
+    public typealias Index = BijectiveDictionary<Left, Right>.Index
+
+    @inlinable public var startIndex: Index { Index(_ltr.startIndex) }
+    @inlinable public var endIndex: Index { Index(_ltr.endIndex) }
+
+    @inlinable
+    public func index(after i: Index) -> Index {
+        Index(_ltr.index(after: i._ltrIndex))
+    }
+
+    @inlinable
+    public subscript(position: Index) -> Right {
+        _ltr[position._ltrIndex].value
+    }
+}
 // MARK: - Other Conformances
 
 extension BijectiveDictionary.RightValues: CustomStringConvertible {

diff --git a/Tests/BijectiveDictionaryTests/BijectiveDictionaryTests.swift b/Tests/BijectiveDictionaryTests/BijectiveDictionaryTests.swift
@@ -193,11 +193,23 @@ func collection(dict: BijectiveDictionary<String, Int>) {
 @Test func leftValues() {
     let dict: BijectiveDictionary = ["A": 1, "B": 2, "C": 3]
     #expect(Set(dict.leftValues) == ["A", "B", "C"])
+
+    let leftValues = dict.leftValues
+    let assertions = ["A", "B", "C"]
+    for assertion in assertions {
+        #expect(leftValues.contains(assertion))
+    }
 }
 
 @Test func rightValues() {
     let dict: BijectiveDictionary = ["A": 1, "B": 2, "C": 3]
     #expect(Set(dict.rightValues) == [1, 2, 3])
+
+    let rightValues = dict.rightValues
+    let assertions = [1, 2, 3]
+    for assertion in assertions {
+        #expect(rightValues.contains(assertion))
+    }
 }
 
 @Test("leftValues and rightValues should have the same order")