Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(VpcPeering): improve tutorial to identify correct principals #992

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

vandjelk
Copy link
Contributor

@vandjelk vandjelk commented Jan 30, 2025

Updates tutorials with links to Cloud Manager principals that should be used depending on the Kyma landscape.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
@vandjelk vandjelk marked this pull request as ready for review January 30, 2025 15:30
@vandjelk vandjelk requested a review from a team as a code owner January 30, 2025 15:30
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 31, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 31, 2025
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@vandjelk vandjelk enabled auto-merge (squash) January 31, 2025 13:58
@vandjelk vandjelk merged commit ee13277 into kyma-project:main Jan 31, 2025
14 checks passed
@vandjelk vandjelk deleted the peering/docs/identify-principal branch January 31, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants