Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKR Status #977

Merged
merged 6 commits into from
Jan 21, 2025
Merged

SKR Status #977

merged 6 commits into from
Jan 21, 2025

Conversation

tmilos77
Copy link
Contributor

Description

Changes proposed in this pull request:

  • reduce amount of log entries by not logging when connecting to the SKR but produce an SkrStatus KCP resource instead

Related issue(s)

@tmilos77 tmilos77 requested a review from a team as a code owner January 20, 2025 10:24
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2025
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2025
@tmilos77 tmilos77 requested a review from a team as a code owner January 21, 2025 10:57
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 21, 2025
@tmilos77 tmilos77 enabled auto-merge (squash) January 21, 2025 11:06
@tmilos77 tmilos77 merged commit b67c0ce into kyma-project:main Jan 21, 2025
14 checks passed
@tmilos77 tmilos77 deleted the skr-status branch January 21, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dushanpantic dushanpantic dushanpantic left review comments

@vandjelk vandjelk vandjelk approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@vandjelk vandjelk

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmilos77 @vandjelk @dushanpantic @mmitoraj @kyma-bot