Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Nuke): Clean up of AWS Recovery Points when SKR is deleted #872

Merged
merged 5 commits into from
Dec 18, 2024
Merged

feat(Nuke): Clean up of AWS Recovery Points when SKR is deleted #872

merged 5 commits into from
Dec 18, 2024

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Aws Client for listing and deleting the Recovery points
  • Nuke reconciler components to delete recovery points.

Related issue(s)

Part of #863

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2024
@ravi-shankar-sap ravi-shankar-sap force-pushed the aws-nfs-backup branch 2 times, most recently from 1b731ef to 217f1e6 Compare December 16, 2024 21:55
@ravi-shankar-sap ravi-shankar-sap removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@ravi-shankar-sap ravi-shankar-sap marked this pull request as ready for review December 16, 2024 22:11
@ravi-shankar-sap ravi-shankar-sap requested a review from a team as a code owner December 16, 2024 22:11
@ravi-shankar-sap ravi-shankar-sap force-pushed the aws-nfs-backup branch 4 times, most recently from 36af95d to 6701e90 Compare December 16, 2024 23:10
abalaie
abalaie reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1 suggestion. And I have one question as well. Does this need any new permission? if it does, please update aws-permissions.md as well.

@ravi-shankar-sap @abalaie
Update config/featureToggles/featureToggles.yaml
9eff844 
Co-authored-by: Amir Balaie <137324761+abalaie@users.noreply.github.com>
@ravi-shankar-sap
Copy link
Contributor Author

Added 1 suggestion. And I have one question as well. Does this need any new permission? if it does, please update aws-permissions.md as well.

Hello Amir, No additional AWS permissions is needed. The existing permissions set already included deleteRecoveryPoint and listRecoveryPointsByVault permissions, and so no new permissions are required

@ravi-shankar-sap ravi-shankar-sap force-pushed the aws-nfs-backup branch 2 times, most recently from cf32ffa to b2c8948 Compare December 18, 2024 20:07
abalaie
abalaie previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@abalaie abalaie self-requested a review December 18, 2024 20:10
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 18, 2024
abalaie
abalaie approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@ravi-shankar-sap ravi-shankar-sap merged commit 1028191 into kyma-project:main Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalaie abalaie abalaie approved these changes

Assignees

@abalaie abalaie

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-shankar-sap @abalaie @kyma-bot