feat(AwsVpcPeering): capitalize status state #823
Conversation
kyma-bot
added
cla: yes
| const ( | ||
| VpcPeeringConnectionStateReasonCodeInitiatingRequest = "Initiating-Request" | ||
| VpcPeeringConnectionStateReasonCodePendingAcceptance = "Pending-Acceptance" | ||
| VpcPeeringConnectionStateReasonCodeActive = "Active" | ||
| VpcPeeringConnectionStateReasonCodeDeleted = "Deleted" | ||
| VpcPeeringConnectionStateReasonCodeRejected = "Rejected" | ||
| VpcPeeringConnectionStateReasonCodeFailed = "Failed" | ||
| VpcPeeringConnectionStateReasonCodeExpired = "Expired" | ||
| VpcPeeringConnectionStateReasonCodeProvisioning = "Provisioning" | ||
| VpcPeeringConnectionStateReasonCodeDeleting = "Deleting" | ||
| ) |
There was a problem hiding this comment.
Please correct me if I am wrong, but these statuses will only be used for the AWS peering, correct?
If that is the case, perhaps they should be named in a way that reflects that, just to remove potential future confusion.
There was a problem hiding this comment.
Yes, these statuses will only be used by AWS until we align them all.
My opinion is that these statuses should reflect the statuses from underlying hyperscaler subscription, but the thing is that GCP is already, maybe accidently, follows Azure statuses (Connected, Initiated, Disconnected, Deleted) so as @tmilos77 stated - ideally align them all.
There was a problem hiding this comment.
I believe GCP natively uses "Active" as well, but it is custom mapped to show Connected.
@bru-jer-work any opinions?
kyma-bot
added
size/L
vandjelk
changed the title
Description
Changes proposed in this pull request: