Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws mock & envtest suite #57

Merged
merged 6 commits into from
Jan 29, 2024
Merged

aws mock & envtest suite #57

merged 6 commits into from
Jan 29, 2024

Conversation

tmilos77
Copy link
Contributor

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2024
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2024
* commit 'd265153f7cc1af0ee866f67d706dc7d7f6ec7621':
  GCP NFS Validations
  Adding GcpNfsVolume CR

# Conflicts:
#	components/kcp/cmd/main.go
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 25, 2024
* commit 'fd237a5e959c3704e1df674a424a3f672c6e3151':
  Identifying and adding actions for gcpNfsVolume
  GCP NfsInstance Validations
  (PHX-35) Updating GcpNfsVolume CR and adding parts of SKR reconciler for it
@tmilos77 tmilos77 marked this pull request as ready for review January 29, 2024 10:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@tmilos77 tmilos77 requested a review from vandjelk January 29, 2024 10:51
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 29, 2024
@vandjelk vandjelk merged commit f501eb1 into kyma-project:main Jan 29, 2024
4 checks passed
@tmilos77 tmilos77 deleted the aws-mock branch January 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants