Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GcpNfsVolume CR #56

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Adding GcpNfsVolume CR #56

merged 1 commit into from
Jan 24, 2024

Conversation

abalaie
Copy link
Contributor

@abalaie abalaie commented Jan 24, 2024

GcpNfsVolume CR

Changes proposed in this pull request:

  • Adding the GcpNfsVolume CR created via kubebuilder

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2024
ravi-shankar-sap
ravi-shankar-sap approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2024
@kyma-bot kyma-bot merged commit 9e8e906 into kyma-project:main Jan 24, 2024
4 checks passed
@kyma-bot
Copy link
Contributor

@contributor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
vandjelk_test_of_prowjob_pull-cloud-resources-manager-image 021b6cc link false /test pull-cloud-resources-manager-image

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abalaie abalaie deleted the ab-gcpnfsvolume-cr branch February 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-shankar-sap ravi-shankar-sap ravi-shankar-sap approved these changes

@vandjelk vandjelk Awaiting requested review from vandjelk

@tmilos77 tmilos77 Awaiting requested review from tmilos77

Assignees

@ravi-shankar-sap ravi-shankar-sap

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abalaie @kyma-bot @ravi-shankar-sap