Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding patch API to FilestoreClient and some small fixes #51

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Adding patch API to FilestoreClient and some small fixes #51

merged 1 commit into from
Jan 22, 2024

Conversation

abalaie
Copy link
Contributor

@abalaie abalaie commented Jan 20, 2024

FileStore Patch

Changes proposed in this pull request:

  • adding patch API to FilestoreClient
  • getting the project number from cloud resource manager
  • fixing the issue that delete network services connection doesn't work with project id and instead needs a project number

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2024
@kyma-bot kyma-bot merged commit 654f7d1 into kyma-project:main Jan 22, 2024
4 checks passed
@abalaie abalaie deleted the ab-filstore-patch branch February 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmilos77 tmilos77 tmilos77 approved these changes

@vandjelk vandjelk Awaiting requested review from vandjelk

@ravi-shankar-sap ravi-shankar-sap Awaiting requested review from ravi-shankar-sap

Assignees

@tmilos77 tmilos77

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abalaie @tmilos77 @kyma-bot