Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: user tutorial for GCP NFS #332

Merged
merged 6 commits into from
Jul 16, 2024
Merged

docs: user tutorial for GCP NFS #332

merged 6 commits into from
Jul 16, 2024

Conversation

abalaie
Copy link
Contributor

@abalaie abalaie commented Jul 10, 2024

Description

Changes proposed in this pull request:

  • user tutorial for GCP NFS
  • small changes to glossary
  • small changes to gcpNfsVolume CRD document

Related issue(s)

@abalaie abalaie requested a review from a team July 10, 2024 00:25
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@abalaie abalaie marked this pull request as ready for review July 10, 2024 17:15
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@abalaie abalaie requested a review from a team July 10, 2024 17:15
@abalaie abalaie force-pushed the ab-gcp-nfs-tutorial branch from 97bf6ec to 30ea87f Compare July 12, 2024 04:37
@abalaie
Copy link
Contributor Author

abalaie commented Jul 12, 2024

Updated the document to be in sync with recent changes.

@tmilos77 tmilos77 mentioned this pull request Jul 15, 2024
Closed
12 tasks
@tmilos77 tmilos77 added this to the Cloud Manager GA v1.0 milestone Jul 15, 2024
mmitoraj
mmitoraj reviewed Jul 15, 2024
View reviewed changes
@tmilos77 @mmitoraj
Apply suggestions from code review
6293376 
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@tmilos77 tmilos77 requested a review from mmitoraj July 15, 2024 12:31
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
mmitoraj
mmitoraj requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the tutorial to the list in _sidebar.md.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2024
@abalaie abalaie changed the base branch from main to init July 15, 2024 23:43
@abalaie abalaie changed the base branch from init to main July 15, 2024 23:43
@kyma-bot kyma-bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 15, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2024
@abalaie
Copy link
Contributor Author

abalaie commented Jul 15, 2024

I rebased the code as it had some conflicts with the base and the option was not available on the UI.
But then it showed many commits that were already merged to the "main" branch. So based on Github suggestions on the same issue, I changed the base branch to something else and again back to main, so that the base branch commit get updated and it only shows the relevant changes. And it worked.

@abalaie abalaie requested a review from mmitoraj July 15, 2024 23:46
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot merged commit 015f467 into kyma-project:main Jul 16, 2024
7 checks passed
@abalaie abalaie deleted the ab-gcp-nfs-tutorial branch September 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@tmilos77 tmilos77 tmilos77 approved these changes

Assignees

@mmitoraj mmitoraj

@tmilos77 tmilos77

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0 - NFS GA
Development

Successfully merging this pull request may close these issues.
4 participants
@abalaie @kyma-bot @mmitoraj @tmilos77