Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GcpRedisInstance): add auth settings to API #326

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat(GcpRedisInstance): add auth settings to API #326

merged 2 commits into from
Jul 8, 2024

Conversation

dushanpantic
Copy link
Contributor

Description

Changes proposed in this pull request:

  • allow user to define if auth is enabled .spec.authEnabled
  • allow user to define transit encryption mode .spec.transitEncryptionMode
  • show Deleting state while GcpRedisInstance is being deleted

Related issue(s)

@dushanpantic dushanpantic requested a review from a team as a code owner July 8, 2024 11:45
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2024
ijovovic
ijovovic approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2024
@kyma-bot kyma-bot merged commit 5548e44 into kyma-project:main Jul 8, 2024
6 checks passed
@dushanpantic dushanpantic deleted the add-auth-to-gcpredis branch July 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijovovic ijovovic ijovovic approved these changes

Assignees

@ijovovic ijovovic

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dushanpantic @ijovovic @kyma-bot