docs: user documentation for NFS #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
size/XL
Closed
mmitoraj
reviewed
Jul 4, 2024
There was a problem hiding this comment.
- I will create a follow-up task to update the diagrams as per our guidelines.
- The main README in the repo requires updating, we can create a follow-up for that as well.
- I'm thinking about creating a glossary document for all the terms, such as AWS EFS, RWX, CIDR. Maybe we could explain those abbreviations in one doc and provide some basic details about the terms?
mmitoraj
reviewed
Jul 5, 2024
Comment on lines
160
to
188
| * Remove the created workloads: | ||
| ```shell | ||
| kubectl delete -n $NAMESPACE deployment awsnfsvolume-demo | ||
| ``` | ||
|
|
||
| * Remove the created configmap: | ||
| ```shell | ||
| kubectl delete -n $NAMESPACE configmap my-script | ||
| ``` | ||
|
|
||
| * Remove the created awsnfsvolume: | ||
| ```shell | ||
| kubectl delete -n $NAMESPACE awsnfsvolume my-vol | ||
| ``` | ||
|
|
||
| * Remove the created default iprange: | ||
|
|
||
| > [!NOTE] | ||
| > If you have other cloud resources using the default IpRange, | ||
| > skip this step, and do not delete the default IpRange. | ||
|
|
||
| ```shell | ||
| kubectl delete -n kyma-system iprange default | ||
| ``` | ||
|
|
||
| * Remove the created namespace: | ||
| ```shell | ||
| kubectl delete namespace $NAMESPACE | ||
| ``` |
There was a problem hiding this comment.
We could indent those bullet points so that they show up under step 8.
mmitoraj
approved these changes
Jul 5, 2024
mmitoraj
approved these changes
Jul 5, 2024
vandjelk
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)