Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) UI Documentation #309

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

kevin-kho
Copy link
Contributor

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

@kevin-kho kevin-kho requested a review from a team as a code owner July 2, 2024 00:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2024
Copy link
Contributor

@tmilos77 tmilos77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should align with Kyma Content Guidelines. Think this is better suited to docs/contributor/ui.md or docs/contributor/ui/README.md

@kevin-kho kevin-kho force-pushed the kh-ui-documentation branch from 12926ee to b19f6fb Compare July 8, 2024 17:10
@kevin-kho
Copy link
Contributor Author

We should align with Kyma Content Guidelines. Think this is better suited to docs/contributor/ui.md or docs/contributor/ui/README.md

Moved it to docs/contributo/ui/README.md on commit 4011b5a

@kevin-kho kevin-kho requested a review from tmilos77 July 9, 2024 14:57
@tmilos77 tmilos77 requested a review from a team July 10, 2024 15:10
@tmilos77 tmilos77 mentioned this pull request Jul 15, 2024
12 tasks
@tmilos77 tmilos77 added this to the Cloud Manager GA v1.0 milestone Jul 15, 2024
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried to describe the process in Create Your Module User Interface, It would be great to improve it though using your steps for generating, deploying, and testing.

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
@tmilos77 tmilos77 requested a review from mmitoraj July 15, 2024 12:34
@kyma-bot kyma-bot merged commit e011867 into kyma-project:main Jul 15, 2024
7 checks passed
@kevin-kho kevin-kho deleted the kh-ui-documentation branch July 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants