feat: Cceenfsvolume #1009
Merged
feat: Cceenfsvolume #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmilos77
added
the
do-not-merge/hold
kyma-bot
added
cla: yes
tmilos77
added
do-not-merge/hold
tmilos77
force-pushed
the
cceenfsvolume
branch
from
741618e to
dde41a0
Compare
tmilos77
removed
the
do-not-merge/hold
dushanpantic
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Beside the comments I left, I have also noticed that the naming convention is not consistent.
Some files are in camel case (e.g.kcpNfsInstanceCreate.go, while others are a mix of camel case and snake case (e.g. pv_create.go)
Perhaps we should be consistent here?
internal/controller/cloud-resources/cceenfsvolume_controller_test.go
Outdated
Show resolved
Hide resolved
internal/controller/cloud-resources/cceenfsvolume_controller_test.go
Outdated
Show resolved
Hide resolved
dushanpantic
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)