Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(AzureVpcPeering): tutorial split down #1003

Conversation

vandjelk
Copy link
Contributor

@vandjelk vandjelk commented Feb 3, 2025

No description provided.

@vandjelk vandjelk requested a review from mmitoraj February 3, 2025 15:16
@vandjelk vandjelk self-assigned this Feb 3, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2025
@@ -6,7 +6,7 @@ This tutorial explains how to create a Virtual Private Cloud (VPC) peering conne

* You have the Cloud Manager module added.

## Steps <!-- {docsify-ignore} -->
## Authorize Cloud Manager in remote subscription <!-- {docsify-ignore} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Authorize Cloud Manager in remote subscription <!-- {docsify-ignore} -->
## Steps
### Authorize Cloud Manager in the Remote Subscription <!-- {docsify-ignore} -->

@@ -6,7 +6,7 @@ This tutorial explains how to create a Virtual Private Cloud (VPC) peering conne

* You have the Cloud Manager module added.

## Steps <!-- {docsify-ignore} -->
## Authorize Cloud Manager in remote subscription <!-- {docsify-ignore} -->

1. Log in to Azure and set the active subscription:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Log in to Azure and set the active subscription:
1. Log in to your Azure account and set the active subscription:

@@ -31,21 +31,23 @@ This tutorial explains how to create a Virtual Private Cloud (VPC) peering conne
--scope "/subscriptions/$SUBSCRIPTION_ID"
```

3. Set the region that is closest to your Kyma cluster. Use `az account list-locations` to list available locations.
## Setup test environment in remote subscription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Setup test environment in remote subscription
### Set Up a Test Environment in the Remote Subscription

@@ -74,15 +76,19 @@ This tutorial explains how to create a Virtual Private Cloud (VPC) peering conne
export IP_ADDRESS=$(az vm show --show-details --resource-group $RESOURCE_GROUP_NAME --name $VM_NAME --query privateIps --output tsv)
```

7. Tag the VPC network with the Kyma shoot name:
## Allow Kyma to peer with your network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Allow Kyma to peer with your network
### Allow Kyma to Peer with Your Network

7. Tag the VPC network with the Kyma shoot name:
## Allow Kyma to peer with your network

1. Tag the VPC network with the Kyma shoot name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Tag the VPC network with the Kyma shoot name:
1. Tag your VPC network with the Kyma shoot name:

In the above line, you used "your", let's be consistent.


```shell
export SHOOT_NAME=$(kubectl get cm -n kube-system shoot-info -o jsonpath='{.data.shootName}')
export VNET_ID=$(az network vnet show --name $VNET_NAME --resource-group $RESOURCE_GROUP_NAME --query id --output tsv)
az tag update --resource-id $VNET_ID --operation Merge --tags $SHOOT_NAME
```

8. Create an AzureVpcPeering resource:
## Create AzureVpcPeering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Create AzureVpcPeering
### Create Azure VPC Peering

@vandjelk vandjelk closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants