Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch sap-btp-operator-controller-manager #924

Merged
merged 17 commits into from
Dec 18, 2024
Merged

Watch sap-btp-operator-controller-manager #924

merged 17 commits into from
Dec 18, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Dec 11, 2024 •
edited
Loading

Description

Test scenario 1:

  • Patch sap-btp-operator deployment with non existing image
  • Delete sap-btp-operator pod
  • Wait for sap-btp-operator deployment to be in error
  • Wait for sap-btp-operator deployment to be reconciled and ready

Test scenario 2:

  • Patch sap-btp-operator-config configmap with random culster_id
  • Delete sap-btp-operator pod
  • Wait for btpOperator CR to be in error
  • Patch back sap-btp-operator-config configmap
  • Wait for btpOperator CR to be ready

Changes proposed in this pull request:

  • Watch sap-btp-operator-controller-manager state change
  • Add 2 E2E tests

Related issue(s)

See #913

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Dec 11, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2024
@MarekMichali MarekMichali marked this pull request as ready for review December 16, 2024 13:14
@MarekMichali MarekMichali requested a review from a team as a code owner December 16, 2024 13:14
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@MarekMichali
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) December 16, 2024 13:14
@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Dec 16, 2024
@MarekMichali MarekMichali removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@szwedm
Copy link
Contributor

szwedm commented Dec 18, 2024

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@szwedm szwedm self-requested a review December 18, 2024 08:42
@jaroslaw-pieszka jaroslaw-pieszka self-requested a review December 18, 2024 08:56
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@MarekMichali @jaroslaw-pieszka
Update controllers/btpoperator_controller.go
51ebed7 
Co-authored-by: Jarosław Pieszka <jaroslaw.pieszka@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
szwedm
szwedm approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@szwedm
Copy link
Contributor

szwedm commented Dec 18, 2024

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit b8fa34a into kyma-project:main Dec 18, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

@szwedm szwedm szwedm approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

@MarekMichali MarekMichali

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarekMichali @szwedm @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot