Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of Unnecessary Error Banner #846

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Removal of Unnecessary Error Banner #846

merged 1 commit into from
Aug 23, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 23, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Removed error banner that added "no entries" message when any error occurs - such behaviour was unnecessary since error message has its place at the top of the table and it disabled rendering of existing instances after removal of one instance failed.

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Aug 23, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2024
@ralikio ralikio added kind/bug Categorizes issue or PR as related to a bug. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2024
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2024
@ralikio ralikio changed the base branch from main to sm-integration August 23, 2024 11:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2024
@ralikio ralikio marked this pull request as ready for review August 23, 2024 11:51
@ralikio ralikio requested a review from a team as a code owner August 23, 2024 11:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 23, 2024
@MarekMichali MarekMichali merged commit b9c92d5 into kyma-project:sm-integration Aug 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @kyma-bot @MarekMichali