Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues reported by golangci #623

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix issues reported by golangci #623

merged 2 commits into from
Mar 1, 2024

Conversation

KsaweryZietara
Copy link
Contributor

@KsaweryZietara KsaweryZietara commented Feb 29, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • create golangci-lint workflow,
  • update golangci-lint in Makefile,
  • fix golangci errors.

Related issue(s)
Resolves #486

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Feb 29, 2024
@KsaweryZietara KsaweryZietara self-assigned this Feb 29, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner February 29, 2024 12:06
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 29, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 1, 2024
@kyma-bot kyma-bot merged commit 157434b into kyma-project:main Mar 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix issues reported by golangci
3 participants
@KsaweryZietara @piotrmiskiewicz @kyma-bot